[PATCH] D134726: [AMDGPU][SetWavePriority] Fix dealing with MBBInfo records.
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 27 07:04:11 PDT 2022
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSetWavePriority.cpp:150-152
SuccsMayReachVMEMLoad |= MBBInfos[Succ].MayReachVMEMLoad;
NumFollowingVALUInsts =
std::max(NumFollowingVALUInsts, MBBInfos[Succ].NumVALUInstsAtStart);
----------------
kosarev wrote:
> These potentially invalidate `Info`.
Doesn't this imply it's reading uncomputed values for the successors? Don't those need to be computed for this to do something sensible?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134726/new/
https://reviews.llvm.org/D134726
More information about the llvm-commits
mailing list