[PATCH] D133923: [Release] Add bump-version script.

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

I put some comments, but overall lgtm as in the end it's going to be you and Tom who run it.



================
Comment at: llvm/utils/release/bump-version.py:194
+    )
+    parser.add_argument("version", help="Version to bump to, i.e. 15.0.1", default=None)
+    parser.add_argument("--rc", default=None, type=int, help="RC version")
----------------
s/i.e./e.g./


================
Comment at: llvm/utils/release/bump-version.py:196
+    parser.add_argument("--rc", default=None, type=int, help="RC version")
+    parser.add_argument("-s", "--source-root", default=None, help="Source Root")
+
----------------
Maybe add an example, like /foo/llvm-project/ ? Could this default to the current working directory?

Oh I see later on that it refers to the source root of this file. Maybe the help text could mention that somehow.


================
Comment at: llvm/utils/release/bump-version.py:215
+
+    files_to_update = (
+        # Main CMakeLists.
----------------
This is very sparse, especially with all the newlines. Could it be just

```
[
("llvm/utils/gn/secondary/llvm/version.gni", GNIProcessor())}
...
]
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133923/new/

https://reviews.llvm.org/D133923