[PATCH] D125776: [llvm-debuginfo-analyzer] 01 - Interval tree

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added inline comments.


================
Comment at: llvm/unittests/ADT/IntervalTreeTest.cpp:103
+  Intervals = Tree.getContaining(Point);
+  ASSERT_EQ(Intervals.size(), 1);
+  CheckData(Point, Intervals[0], 10, 20, 10.20);
----------------
Hi,

Compiling with clang 8 I get the following warning here:
```
11:37:12 In file included from ../unittests/ADT/IntervalTreeTest.cpp:10:
11:37:12 ../utils/unittest/googletest/include/gtest/gtest.h:1526:11: error: comparison of integers of different signs: 'const unsigned long' and 'const int' [-Werror,-Wsign-compare]
11:37:12   if (lhs == rhs) {
11:37:12       ~~~ ^  ~~~
11:37:12 ../utils/unittest/googletest/include/gtest/gtest.h:1553:12: note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long, int>' requested here
11:37:12     return CmpHelperEQ(lhs_expression, rhs_expression, lhs, rhs);
11:37:12            ^
11:37:12 ../unittests/ADT/IntervalTreeTest.cpp:103:3: note: in instantiation of function template specialization 'testing::internal::EqHelper::Compare<unsigned long, int, nullptr>' requested here
11:37:12   ASSERT_EQ(Intervals.size(), 1);
11:37:12   ^
11:37:12 ../utils/unittest/googletest/include/gtest/gtest.h:2056:32: note: expanded from macro 'ASSERT_EQ'
11:37:12 # define ASSERT_EQ(val1, val2) GTEST_ASSERT_EQ(val1, val2)
11:37:12                                ^
11:37:12 ../utils/unittest/googletest/include/gtest/gtest.h:2040:54: note: expanded from macro 'GTEST_ASSERT_EQ'
11:37:12   ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
11:37:12                                                      ^
11:37:12 1 error generated.
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125776/new/

https://reviews.llvm.org/D125776