[PATCH] D134354: [AMDGPU][GlobalISel] Support mad/fma_mix selection

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 27 03:19:46 PDT 2022


Pierre-vh updated this revision to Diff 463165.
Pierre-vh marked 4 inline comments as done.
Pierre-vh added a comment.

- Address comments
- Fix failing tablegen test
- Change tests to use fneg instead of fsub, as discussed.
  - v_mad_mix_f32_preextractfabsfneg_f16hi_f16lo_f16lo now uses -[v0| because of it, some other tests also use -v0 instead now.
- ​Update Value Tracking functions to fix some additional test cases


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134354/new/

https://reviews.llvm.org/D134354

Files:
  llvm/lib/CodeGen/GlobalISel/Utils.cpp
  llvm/lib/Target/AMDGPU/AMDGPUGISel.td
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/lib/Target/AMDGPU/VOP3PInstructions.td
  llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fma-add-ext-fma.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fma-add-ext-mul.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fma-sub-ext-mul.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fma-sub-ext-neg-mul.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/fmed3.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/mad-mix-hi.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/mad-mix-lo.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/mad-mix.ll
  llvm/test/TableGen/GlobalISelEmitter.td
  llvm/utils/TableGen/GlobalISelEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134354.463165.patch
Type: text/x-patch
Size: 117023 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220927/24d6a8d0/attachment-0001.bin>


More information about the llvm-commits mailing list