[PATCH] D134600: [RISCV][LLD] Add RISCV zcmt optimise in linker relaxation

Sinan Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 27 01:37:22 PDT 2022


sinan added inline comments.


================
Comment at: lld/ELF/SyntheticSections.cpp:1165
+TableJumpSection::TableJumpSection()
+    : SyntheticSection(SHF_ALLOC | SHF_WRITE, SHT_PROGBITS,
+                       config->wordsize, "__tbljalvec_base$") {}
----------------
SHF_ALLOC | SHF_EXECINSTR is more appropriate IMO
(https://github.com/riscv/riscv-code-size-reduction/blob/main/Zc-specification/tablejump.adoc#table-jump-fault-handling)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134600/new/

https://reviews.llvm.org/D134600



More information about the llvm-commits mailing list