[PATCH] D134690: [MC][nfc] Update arm64-leaf-compact-unwind.s to use llvm-objdump

[James Henderson via Phabricator via llvm-commits]

jhenderson resigned from this revision.
jhenderson added a comment.

I'm afraid my Mach-O knowledge is too limited to be able to confidently state that we're not losing coverage by transitioning from one to the other. Sorry.



================
Comment at: llvm/test/MC/AArch64/arm64-leaf-compact-unwind.s:7
 
-// FIXME: we should add compact unwind support to llvm-objdump --unwind-info
-
-// CHECK:      Section {
-// CHECK:        Index: 1
-// CHECK-NEXT:   Name: __compact_unwind
-// CHECK-NEXT:   Segment: __LD
-// CHECK-NEXT:   Address:
-// CHECK-NEXT:   Size:
-// CHECK-NEXT:   Offset:
-// CHECK-NEXT:   Alignment:
-// CHECK-NEXT:   RelocationOffset:
-// CHECK-NEXT:   RelocationCount:
-// CHECK-NEXT:   Type:
-// CHECK-NEXT:   Attributes [
-// CHECK-NEXT:     Debug
-// CHECK-NEXT:   ]
-// CHECK-NEXT:   Reserved1:
-// CHECK-NEXT:   Reserved2:
-// CHECK-NEXT:   Reserved3:
-// CHECK-NEXT:   Relocations [
-// CHECK-NEXT:     Relocation {
-// CHECK-NEXT:       Offset: 0x60
-// CHECK-NEXT:       PCRel: 0
-// CHECK-NEXT:       Length: 3
-// CHECK-NEXT:       Type: ARM64_RELOC_UNSIGNED (0)
-// CHECK-NEXT:       Section: __text (1)
-// CHECK-NEXT:     }
-// CHECK-NEXT:     Relocation {
-// CHECK-NEXT:       Offset: 0x40
-// CHECK-NEXT:       PCRel: 0
-// CHECK-NEXT:       Length: 3
-// CHECK-NEXT:       Type: ARM64_RELOC_UNSIGNED (0)
-// CHECK-NEXT:       Section: __text (1)
-// CHECK-NEXT:     }
-// CHECK-NEXT:     Relocation {
-// CHECK-NEXT:       Offset: 0x20
-// CHECK-NEXT:       PCRel: 0
-// CHECK-NEXT:       Length: 3
-// CHECK-NEXT:       Type: ARM64_RELOC_UNSIGNED (0)
-// CHECK-NEXT:       Section: __text (1)
-// CHECK-NEXT:     }
-// CHECK-NEXT:     Relocation {
-// CHECK-NEXT:       Offset: 0x0
-// CHECK-NEXT:       PCRel: 0
-// CHECK-NEXT:       Length: 3
-// CHECK-NEXT:       Type: ARM64_RELOC_UNSIGNED (0)
-// CHECK-NEXT:       Section: __text (1)
-// CHECK-NEXT:     }
-// CHECK-NEXT:   ]
-// CHECK-NEXT:   SectionData (
-// CHECK-NEXT:     0000: 00000000 00000000 08000000 00000002
-// CHECK-NEXT:     0010: 00000000 00000000 00000000 00000000
-// CHECK-NEXT:     0020: 08000000 00000000 40000000 00900002
-// CHECK-NEXT:     0030: 00000000 00000000 00000000 00000000
-// CHECK-NEXT:     0040: 48000000 00000000 D4000000 0F400002
-// CHECK-NEXT:     0050: 00000000 00000000 00000000 00000000
-// CHECK-NEXT:     0060: 1C010000 00000000 54000000 10100202
-// CHECK-NEXT:     0070: 00000000 00000000 00000000 00000000
-// CHECK-NEXT:   )
-// CHECK-NEXT: }
+# CHECK:      Contents of __compact_unwind section:
+# CHECK-NEXT:   Entry at offset 0x0:
----------------
Nit: if you're changing the comment character used, change it throughout the test, not just in part of the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134690/new/

https://reviews.llvm.org/D134690