[PATCH] D134375: [LTO][AIX] Invoking AIX System Assembler in LTO CodeGen

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 20:16:51 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:120
+cl::opt<std::string> SystemAssemblerPath(
+    "lto-system-assembler",
+    cl::desc("Absolute path to the system assembler, picked up on AIX only"),
----------------
This option needs an AIX specific name.


================
Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:251
+
+void LTOCodeGenerator::setupForAIXSystemAssembler() {
+  setFileType(CGFT_AssemblyFile);
----------------
Remove this function. Inline its use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134375/new/

https://reviews.llvm.org/D134375



More information about the llvm-commits mailing list