[PATCH] D133914: [InlineAsm][bugfix] Correct function addressing in inline asm

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:8723
 
+static bool isFunction(SDValue &Op) {
+  if (Op.getNode() && Op.getOpcode() == ISD::GlobalAddress) {
----------------
RKSimon wrote:
> Pass SDValue by value not reference
Make sense! Here we not change the Op, thanks for reviewing!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133914/new/

https://reviews.llvm.org/D133914