[PATCH] D134663: [LoopDeletion] Clear block & loop dispo cache after breaking backedge.

Mon Sep 26 13:28:03 PDT 2022

dblaikie added a comment.

In D134663#3816053 <https://reviews.llvm.org/D134663#3816053>, @fhahn wrote:

> In D134663#3816040 <https://reviews.llvm.org/D134663#3816040>, @dblaikie wrote:
>
>> While I guess this is a fix for crash/UB, was the problem covered by any tests or could we add test coverage? (or maybe the failure's so unlikely as to be impractical to test - some ABA allocation situation which rarely occurs?)
>
> Without this change, multiple transform tests fail when LLVM is built with ASAN, so this should be covered by existing tests + buildbots running ASAN.

Ah, sounds good to me, then (though I'll leave it to other folks more familiar with the code to approve) - maybe a link to/quote from one of those failures would be good to include in the commit message.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134663/new/

https://reviews.llvm.org/D134663