[PATCH] D134429: [DebugInfo][LICM] Drop DebugLoc from IntrinsicInst when hoisting

Mon Sep 26 13:18:17 PDT 2022

dblaikie added a comment.

In D134429#3815561 <https://reviews.llvm.org/D134429#3815561>, @jmmartinez wrote:

> In D134429#3815441 <https://reviews.llvm.org/D134429#3815441>, @dblaikie wrote:
>
>> What's the motivation for the change - reduced debug info size by having fewer zero locations?
>
> The idea is to reduce the amount zero locations since they can be confusing for the users.

At least GDB mostly ignores line zero, I think - so what sort of user confusion are you encountering/trying to address? Good to know what the use cases are, etc.

> I thought that dropping the debug location for these kind of intrinsics would consistent with what happens for the rest of the instructions. However, I'm fairly new to the debug-info so I'm not confident about the impact that these changes may have.

Yeah, fair enough - works OK for me.

In D134429#3815692 <https://reviews.llvm.org/D134429#3815692>, @probinson wrote:

> Offhand, handling non-call intrinsic functions the same way as hoisting any other instruction seems like the way to go.

Yeah, sounds OK

> The test case looks like it could be more focused, it doesn't look complicated enough to need to be generated from C source.

Yep, if there's something simpler that'd be great.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134429/new/

https://reviews.llvm.org/D134429