[PATCH] D125417: [ARM64EC 5/?] Fix names of __chkstk and __security_check_cookie.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.h:361
+    if (isWindowsArm64EC())
+      return "__chkstk_arm64ec";
+    return "__chkstk";
----------------
bcl5980 wrote:
> efriedma wrote:
> > bcl5980 wrote:
> > > Do we need to use #__chkstk_arm64ec here?
> > Probably?  I'm still not entirely sure how that interacts with the hybmp table.
> ```
> main_clang.obj : error LNK2019: unresolved external symbol __chkstk_arm64ec referenced in function $iexit_thunk$cdecl$i8$varargs (EC Symbol)
> ```
> It looks we do need add `#` here. This is the link error when I try to link a variadic function. It will disappear after I add `#`.
Hmm, okay... does this specifically apply to `__chkstk_arm64ec` and `__security_check_cookie_arm64ec`, or have you noticed link errors for anything else?  (Trying to confirm if there's some general mangling rule we're missing, or these functions are just weird.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125417/new/

https://reviews.llvm.org/D125417