[PATCH] D134469: [DirectX] Add DXIL metadata `dx.shaderModel`

Xiang Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 11:05:30 PDT 2022


python3kgae added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXILMetadata.cpp:68
+
+void dxil::createShaderModelMD(Module &M) {
+  NamedMDNode *Entry = M.getOrInsertNamedMetadata("dx.shaderModel");
----------------
Shall we add "dx.version" in the function too since it is just shader model with offset on major.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134469/new/

https://reviews.llvm.org/D134469



More information about the llvm-commits mailing list