[PATCH] D114174: [ARM][CodeGen] Add support for complex deinterleaving

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 09:43:58 PDT 2022


dmgreen added a comment.

Have you had any luck adding a larger corpus of tests cases yet? I see that uses have been added to the graph. I would hope that we could avoid that complication, but it is hard to see if we can or not without a larger set of tests.



================
Comment at: llvm/lib/CodeGen/ComplexDeinterleavingPass.cpp:761
+
+    auto RealMask = RealShuffle->getShuffleMask();
+    auto ImagMask = ImagShuffle->getShuffleMask();
----------------
Try not to overuse auto where the type isn't already obvious.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114174/new/

https://reviews.llvm.org/D114174



More information about the llvm-commits mailing list