[PATCH] D134647: [AArch64] Correct v9.x-a Features

Mon Sep 26 09:13:52 PDT 2022

lenary added a comment.

In D134647#3815432 <https://reviews.llvm.org/D134647#3815432>, @dmgreen wrote:

> Do you know if this code is necessary: https://github.com/llvm/llvm-project/blob/53c3664f674cc2f33c8214f493c2c17ce9b4d466/clang/lib/Driver/ToolChains/Arch/AArch64.cpp#L483 ? It is related, and I noticed it recently in other reviews.

That code may be why no test changes were needed. All the target parsing code is so cursed. I think the TargetParser change will affect other non-clang LLVM tools, whereas that code is clang-only. I'm going to do another check or two, to see how load-bearing the clang code is or whether i can remove it now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134647/new/

https://reviews.llvm.org/D134647