[PATCH] D134527: [FunctionAttrs] Infer precise FMRB

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/suggestion.



================
Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:206
+    // Non-call instructions can access either only argument memory, or
+    // argument & other memory, but never inaccessible memory.
+    MRB |= FunctionModRefBehavior::argMemOnly(MR);
----------------
The claim that no instruction other than a call can access inaccessiblememory seems reasonable on the surface, but is a somewhat significant change.  The corner cases would be something like maybe an indirect br.  

If possible, could you separate this into it's own commit for risk reduction?  Having something easy to revert could be helpful.   


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134527/new/

https://reviews.llvm.org/D134527