[PATCH] D133929: [DebugInfo] Produce variadic DBG_INSTR_REFs from ISel

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 07:51:08 PDT 2022


StephenTozer added a comment.

In D133929#3796075 <https://reviews.llvm.org/D133929#3796075>, @jmorse wrote:

> The "arg zero" form of DIExpression is going to be a very common case -- is it uniqued, and would it be worth storing a copy somewhere and just using that?

DIExpressions should be uniqued based on their expression elements, and the `get` should just be a map lookup underneath, so I don't think there should be any issues with duplicate storage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133929/new/

https://reviews.llvm.org/D133929



More information about the llvm-commits mailing list