[PATCH] D132441: Fix FindZ3.cmake's version detection mechanism

[Mikhail Ramalho via Phabricator via llvm-commits]

mikhail.ramalho added a comment.

> You are describing problem with the toolchain here, not with LLVM's cmakes. And, IMO, this should be fixed on the toolchain side (in your case by adding directory with libZ3.dll to the PATH variable). The advantage of `try_run` path is that it is clearly diagnose problems with [broken] toolchain during configuration phase, so instead of getting broken LLVM libs after compilation you get early configuration error.

I wouldn't describe it as a problem, since relying on cmake to download the dependencies is becoming common.

If it also works for cross-compilation, it could simplify the findz3.cmake considerably.

Also, I think it should only download the static z3 lib, right? Otherwise, we could have problems when running clang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132441/new/

https://reviews.llvm.org/D132441