[PATCH] D132490: [LoopVectorize] Emit runtime checks correctly for nested loops

Mon Sep 26 06:47:01 PDT 2022

fhahn requested changes to this revision.
fhahn added a comment.
This revision now requires changes to proceed.

In D132490#3770109 <https://reviews.llvm.org/D132490#3770109>, @kpdev42 wrote:

> In D132490#3748233 <https://reviews.llvm.org/D132490#3748233>, @fhahn wrote:
>
>> In D132490#3748231 <https://reviews.llvm.org/D132490#3748231>, @kpdev42 wrote:
>>
>>> In D132490#3746679 <https://reviews.llvm.org/D132490#3746679>, @fhahn wrote:
>>>
>>>> Thanks for the update. As I mentioned in the previous message, I think it would be good to just land the test in this patch and I'll submit the code change separately. The test looks good to me.
>>>
>>> Thank you fer the review. 
>>> Lets keep buildbot green. Please land both fix and test case on your own
>>
>> Thanks, the idea would be to commit the test first with the checks so it passes without the fix. The fix then only shows the improvements on the test case, so the bots would stay green at all time.
>
> I am afraid that this test does not pass without fix, so far would you like to (a) modify the test, so that it would pass (diff check instead of overlap check) or (b) XFAIL the test or (c) maybe something else?

Oh right, common practice is to generate the (incorrect) check lines for the test so they pass on current `main`, together with a FIXME comment explaining what the current issue is. I did something like that in 6e56779e6bc168a3acd14f9bf2c4fd3fd9d86bd1 <https://reviews.llvm.org/rG6e56779e6bc168a3acd14f9bf2c4fd3fd9d86bd1>.

Anyways, it should be fixed on current `main` by now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132490/new/

https://reviews.llvm.org/D132490