[PATCH] D127765: modify the insertion of freeze instructions for SLU pass

[Ruobing Han via Phabricator via llvm-commits]

drcut added a comment.

In D127765#3814900 <https://reviews.llvm.org/D127765#3814900>, @fhahn wrote:

> Hmm, aren't there other places in the code that rely on instructions being hoisted out by LICM? Unless I am mis-remembering, It's not clear to me if/why freeze should be treated in a special way.

This patch is related to D127698 <https://reviews.llvm.org/D127698>, for migrating SLU from LoopPass to FuncPass. In the original O3 <https://reviews.llvm.org/owners/package/3/> pipeline, both LICM and SLU are in the same LoopPass Manager. After migrating SLU to FuncPass, it will be removed from the LoopPass Manager. So some loops won't be changed by LICM after applying SLU. Thus, we need to apply parts of LICM in SLU. We found the only instruction we need to hoist is the freeze instruction, as it is the only instruction inserted by SLU.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127765/new/

https://reviews.llvm.org/D127765