[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

Stella Laurenzo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 05:12:11 PDT 2022


stellaraccident added a comment.

In D133823#3813169 <https://reviews.llvm.org/D133823#3813169>, @bkramer wrote:

> Code looks good. Were the concerns about naming resolved?

I believe so for this one, which is fairly uncontroversial. Would still like a review by someone on the MLIR side, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133823/new/

https://reviews.llvm.org/D133823



More information about the llvm-commits mailing list