[PATCH] D129372: [DebugInfo][NFC?] Add new MachineOperand type and change DBG_INSTR_REF syntax

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 03:05:16 PDT 2022


StephenTozer added a comment.

In D129372#3795879 <https://reviews.llvm.org/D129372#3795879>, @jmorse wrote:

> Ah, OK, you threw me by having the test updates in the final patch -- IMO better to have them in each patch themselves, as you're going to have to land them like that. Could you stage those test changes into this patch please?

Right, it is somewhat confusing - the reason for this was mainly that this and another patch in this stack both change the way DBG_INSTR_REFs will be printed, and so it would probably create a lot of noise having both patches update every test that uses DBG_INSTR_REF. If you feel it would be better represented with all the changes in each patch exactly as they'll land, then I can do so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129372/new/

https://reviews.llvm.org/D129372



More information about the llvm-commits mailing list