[PATCH] D129727: [ARM64EC 11/?] Add support for lowering variadic indirect calls.

chenglin.bi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 02:57:36 PDT 2022


bcl5980 added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1467
+    setLibcallName(RTLIB::MEMSET, "#memset");
+    setLibcallName(RTLIB::MEMMOVE, "#memmove");
+  }
----------------
efriedma wrote:
> Is this actually necessary?  The linker should resolve plain "memcpy" to something reasonable, I think.
Based on my local test, if I don't add `#` the memcpy will be link into x86 version memcpy and crash at runtime.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129727/new/

https://reviews.llvm.org/D129727



More information about the llvm-commits mailing list