[PATCH] D125776: [llvm-debuginfo-analyzer] 01 - Interval tree

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 02:44:48 PDT 2022


CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/include/llvm/ADT/IntervalTree.h:213
+      : Left(Left), Right(Right), Value(Value) {
+    assert(Left <= Right && "'Left' must be less or equal that 'Right'");
+  }
----------------
probinson wrote:
> 
Changed.


================
Comment at: llvm/unittests/ADT/IntervalTreeTest.cpp:103
+  Intervals = Tree.getContaining(Point);
+  ASSERT_TRUE(Intervals.size() == 1);
+  CheckData(Point, Intervals[0], 10, 20, 10.20);
----------------
probinson wrote:
> 
Replaced all occurrences of `ASSERT_TRUE(cond1 == cond2)` to `ASSERT_EQ(cond1, cond2)`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125776/new/

https://reviews.llvm.org/D125776



More information about the llvm-commits mailing list