[PATCH] D134436: [WebAssembly] Use intrinsics for table.get/set instructions

Mon Sep 26 01:57:59 PDT 2022

asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

This change LGTM, thanks!

Needing one intrinsic per GC type is non-ideal, but the longer term plan to move to a 'wasmref' type (with associated type metadata) once we've fleshed out that prototype and go through necessary RFCs should remove that issue.

I wondered a bit about the properties for the intrinsic, and now I've reminded myself that intrinsics are not speculatable by default I think they're fine as defined.

================
Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:55
+                                           [IntrReadMem]>;
+                                            
+
----------------
Nit: this line seems to have unwanted whitespace (a bunch of spaces)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134436/new/

https://reviews.llvm.org/D134436