[PATCH] D133974: [objcopy] Fix order of Mach-O LINKEDIT pieces during layout

Mon Sep 26 00:05:37 PDT 2022

jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-objcopy/MachO/linkedit-order.test:31
+# CHECK: cmd:             LC_DYSYMTAB
+## FIXME: FileCheck does not support multiplication. 48 = SYMTAB_NSYMS * 16
+# CHECK: indirectsymoff:  [[#DYSYMTAB_INDIRECTSYMOFF: SYMTAB_SYMOFF + 48]]
----------------
FWIW, I don't think it would be too difficult to get FileCheck to support multiplication. If memory serves me rightly, it would just require adding another binop support, so could easily follow the existing addition support.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133974/new/

https://reviews.llvm.org/D133974