[PATCH] D132146: [PowerPC] XCOFF exception section support on the direct assembler path and exception language and reason code lowering from trap intrinsics

[Paul Scoropan via Phabricator via llvm-commits]

pscoro marked 7 inline comments as done.
pscoro added inline comments.


================
Comment at: llvm/lib/MC/MCXCOFFStreamer.cpp:89
+                                               bool hasDebug) {
+  report_fatal_error("emitXCOFFExceptDirective not yet supported for integrated"
+                     "assembler path.");
----------------
shchenz wrote:
> nit: a space after "integrated" and reformat please
ran clang-format after adding the space, no formatting was performed


================
Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-trap-annotations.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \
+; RUN:   --ppc-asm-full-reg-names -mcpu=pwr8 < %s | FileCheck %s
----------------
shchenz wrote:
> Seems like we are testing 32 bit targets in this file? If so, we should use 32 bit triple, like `powerpc-unknown-linux-gnu` `powerpc-unknown-aix`
`powerpc-unknown-aix` already existed, I added `powerpc-unknown-linux-gnu`, no changes to assembly generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132146/new/

https://reviews.llvm.org/D132146