[PATCH] D134078: [AMDGPU] Fix useDeprecatedPositionallyEncodedOperands errors in R600.
James Y Knight via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 25 14:55:35 PDT 2022
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa8c59bcc0198: [AMDGPU] Fix useDeprecatedPositionallyEncodedOperands errors in R600. (authored by jyknight).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134078/new/
https://reviews.llvm.org/D134078
Files:
llvm/lib/Target/AMDGPU/R600.td
llvm/lib/Target/AMDGPU/R600Instructions.td
Index: llvm/lib/Target/AMDGPU/R600Instructions.td
===================================================================
--- llvm/lib/Target/AMDGPU/R600Instructions.td
+++ llvm/lib/Target/AMDGPU/R600Instructions.td
@@ -641,16 +641,16 @@
def FETCH_CLAUSE : R600WrapperInst <(outs),
(ins i32imm:$addr), "Fetch clause starting at $addr:", [] > {
field bits<8> Inst;
- bits<8> num;
- let Inst = num;
+ bits<8> addr;
+ let Inst = addr;
let isCodeGenOnly = 1;
}
def ALU_CLAUSE : R600WrapperInst <(outs),
(ins i32imm:$addr), "ALU clause starting at $addr:", [] > {
field bits<8> Inst;
- bits<8> num;
- let Inst = num;
+ bits<8> addr;
+ let Inst = addr;
let isCodeGenOnly = 1;
}
@@ -1452,8 +1452,8 @@
} // end usesCustomInserter = 1, isCodeGenOnly = 1, isPseudo = 1, Namespace = "AMDGPU"
def TEX_VTX_CONSTBUF :
- InstR600ISA <(outs R600_Reg128:$dst), (ins MEMxi:$ptr, i32imm:$buffer_id), "VTX_READ_eg $dst, $ptr",
- [(set v4i32:$dst, (CONST_ADDRESS ADDRGA_VAR_OFFSET:$ptr, (i32 imm:$buffer_id)))]>,
+ InstR600ISA <(outs R600_Reg128:$dst_gpr), (ins (MEMxi $src_gpr, $src_index):$src, i32imm:$buffer_id), "VTX_READ_eg $dst_gpr, $src",
+ [(set v4i32:$dst_gpr, (CONST_ADDRESS ADDRGA_VAR_OFFSET:$src, (i32 imm:$buffer_id)))]>,
VTX_WORD1_GPR, VTX_WORD0_eg {
let VC_INST = 0;
@@ -1506,7 +1506,7 @@
}
def TEX_VTX_TEXBUF:
- InstR600ISA <(outs R600_Reg128:$dst), (ins MEMxi:$ptr, i32imm:$buffer_id), "TEX_VTX_EXPLICIT_READ $dst, $ptr">,
+ InstR600ISA <(outs R600_Reg128:$dst_gpr), (ins (MEMxi $src_gpr, $src_index):$src, i32imm:$buffer_id), "TEX_VTX_EXPLICIT_READ $dst_gpr, $src">,
VTX_WORD1_GPR, VTX_WORD0_eg {
let VC_INST = 0;
Index: llvm/lib/Target/AMDGPU/R600.td
===================================================================
--- llvm/lib/Target/AMDGPU/R600.td
+++ llvm/lib/Target/AMDGPU/R600.td
@@ -10,8 +10,6 @@
def R600InstrInfo : InstrInfo {
let guessInstructionProperties = 1;
- let noNamedPositionallyEncodedOperands = 1;
- let useDeprecatedPositionallyEncodedOperands = 1;
}
def R600 : Target {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134078.462772.patch
Type: text/x-patch
Size: 2066 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220925/88c53995/attachment.bin>
More information about the llvm-commits
mailing list