[PATCH] D134596: AMDGPU: Handle new address pattern in LowerKernelAttributes introduced by opaque pointers
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 25 12:08:27 PDT 2022
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerKernelAttributes.cpp:114
+ if (!Load)
+ BCI = dyn_cast<BitCastInst>(*U->user_begin());
+ }
----------------
Would be shorter to check for bitcast first
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerKernelAttributes.cpp:121
+ continue;
+ Load = dyn_cast<LoadInst>(*BCI->user_begin()); // LOad from BCI?
+ }
----------------
Typo LOad
================
Comment at: llvm/test/CodeGen/AMDGPU/implicit-arg-v5-opt-opaque-ptr.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -mtriple=amdgcn-amd-amdhsa --amdhsa-code-object-version=5 -S -O3 -opaque-pointers %s | FileCheck -enable-var-scope -check-prefix=GCN %s
+
----------------
Don’t need -O3 or the code object flag
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134596/new/
https://reviews.llvm.org/D134596
More information about the llvm-commits
mailing list