[PATCH] D134535: Propagate Dst and Src alignment for mem{cpy|move}

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAG.h:1062
 
   SDValue getMemcpy(SDValue Chain, const SDLoc &dl, SDValue Dst, SDValue Src,
+                    SDValue Size, Align DstAlign, Align SrcAlign, bool isVol,
----------------
This function has so many arguments (and I actually added another one downstream in the CHERI fork), would it make sense to introduce a struct for some of them (similar to struct MemOp` in TargetLowering?
If one struct for all the copy operands does not sound like a good idea to you, using one that holds SdValue+Align+MachinePointerInfo could also reduce the number of arguments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134535/new/

https://reviews.llvm.org/D134535