[PATCH] D134185: [AVR] Fix useDeprecatedPositionallyEncodedOperands errors.

[James Y Knight via Phabricator via llvm-commits]

jyknight added inline comments.


================
Comment at: llvm/test/MC/AVR/inst-rjmp.s:36
+; INST: rjmp	.+0
+; INST: rjmp	.+0
+; INST: rjmp	.+0
----------------
MaskRay wrote:
> This can use `INST-COUNT-8: `
I'd rather not, just for clarity.


================
Comment at: llvm/test/MC/AVR/inst-sbrs.s:2
 ; RUN: llvm-mc -triple avr -show-encoding < %s | FileCheck %s
+; RUN: llvm-mc -filetype=obj -triple avr < %s \
+; RUN:     | llvm-objdump -d - | FileCheck --check-prefix=INST %s
----------------
MaskRay wrote:
> `< %s` => `%s`
Any particular reason? Most such tests (e.g. the line above) seem to use `< %s` currently.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134185/new/

https://reviews.llvm.org/D134185