[PATCH] D132955: [ARM64EC 13/?] Mangle thunk for arm64ec
chenglin.bi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 23 14:42:28 PDT 2022
bcl5980 added a comment.
In D132955#3812371 <https://reviews.llvm.org/D132955#3812371>, @efriedma wrote:
> Basically, with this patch, the code walks the thunk signature twice: once to figure out the mangling, and once to figure out the LLVM IR signature of the called function. The two walks care about the same properties of the arguments, so ideally we could tie them together. (So, for example, the first function is an integer. That means we mangle it as "i8", use the LLVM IR type "i64", and pass it directly.) I'm concerned the two walks could fall out of sync, and we could end up with edge cases where the mangler doesn't interpret the signature the same way as the code emitting the actual code in the thunk.
Ah, you are right. Thanks for the explanation. I will refine the code later.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132955/new/
https://reviews.llvm.org/D132955
More information about the llvm-commits
mailing list