[PATCH] D129396: [InstCombine] Add support for div, ldiv, lldiv, and imaxdiv folding

[Martin Sebor via Phabricator via llvm-commits]

msebor updated this revision to Diff 462574.
msebor marked an inline comment as done.
msebor added a comment.

Changes in revision 3 of the patch addressing review comments:

- Add missing return statement.
- Remove test for argument bit width >= 16.
- Use `isa` instead of `dyn_cast`.

I'm willing to look into handling this in the front end instead if/when I have time after this is done.  But I'd prefer to land this change first, and then replace it, to abandoning it on the assumption that I will have the time.  I believe this is an improvement as it is (and after D65457 <https://reviews.llvm.org/D65457> the second such attempt to improve things).  Let's not let perfect be the enemy of the good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129396/new/

https://reviews.llvm.org/D129396

Files:
  llvm/include/llvm/Analysis/TargetLibraryInfo.def
  llvm/include/llvm/Transforms/Utils/SimplifyLibCalls.h
  llvm/lib/Analysis/TargetLibraryInfo.cpp
  llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
  llvm/test/Transforms/InstCombine/div-1.ll
  llvm/test/Transforms/InstCombine/div-2.ll
  llvm/test/Transforms/InstCombine/div-3.ll
  llvm/test/Transforms/InstCombine/div-4.ll
  llvm/unittests/Analysis/TargetLibraryInfoTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129396.462574.patch
Type: text/x-patch
Size: 90591 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220923/bb1ec029/attachment-0001.bin>