[PATCH] D134234: [llvm] Support forward-referenced globals with dso_local_equivalent

Leonard Chan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 23 11:30:54 PDT 2022


leonardchan added a comment.

In D134234#3806864 <https://reviews.llvm.org/D134234#3806864>, @nikic wrote:

> These tests should be in llvm/test/Assembler and preferably test round-trip of llvm-as and llvm-dis, as well as verify-uselistorder.

Added llvm-as/dis tests and verify-uselistorder. I still think the codegen tests are necessary though since we still want to test the lowered calls are properly calling the right thing with/without plts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134234/new/

https://reviews.llvm.org/D134234



More information about the llvm-commits mailing list