[PATCH] D134557: [BranchRelaxation] Fall through only if block has no terminators

Brendon Cahoon via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 23 11:28:39 PDT 2022


bcahoon added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/branch-relax-no-terminators.ll:1
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx90a -verify-machineinstrs -amdgpu-s-branch-bits=5 -debug-only=branch-relaxation -o - %s 2>&1 | FileCheck %s
+
----------------
Perhaps the test should check the generated output rather than the debug info?  The debug info is only generated if asserts are enabled, and I'm not sure why it shows the fail/pass criteria.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134557/new/

https://reviews.llvm.org/D134557



More information about the llvm-commits mailing list