[PATCH] D134423: [AMDGPU] Fix vgpr2sgpr copy to scalar operands of buffer instructions.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 23 11:01:59 PDT 2022


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFixSGPRCopies.cpp:922
+            const MachineOperand *soffsetMO =
+                TII->getNamedOperand(U, AMDGPU::OpName::soffset);
+
----------------
I don't understand why we need special cases for particular named operands. Why can't this be inferred from the operand's register class? @alex-t?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134423/new/

https://reviews.llvm.org/D134423



More information about the llvm-commits mailing list