[PATCH] D132566: [SLP] Fix cost model w.r.t. operand properties

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In D132566#3811911 <https://reviews.llvm.org/D132566#3811911>, @reames wrote:

> In D132566#3808619 <https://reviews.llvm.org/D132566#3808619>, @RKSimon wrote:
>
>> LGTM but naturally test coverage would be a plus. Have you had any luck with your multiply by (pow2 and non-pow2) constant example?
>
> JFYI, I'm not ignoring the request for test coverage.  I tried multiple times to come up with a viable test for this, and each time, I'd stumble across an unrelated issue first.  There's so many interacting problems here that finding the right combination of input to trip this difference is effectively impossible. I'm going to work through a couple of the other issues, and hopefully as I do, I can start building a reasonable test corpus.

I feel your pain! Getting everything to work as you'd expect with costs is never straightforward...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132566/new/

https://reviews.llvm.org/D132566