[PATCH] D134388: [Analysis] Make members of InlineCost const (NFC)

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 23 09:51:43 PDT 2022


kazu added a comment.

In D134388#3811157 <https://reviews.llvm.org/D134388#3811157>, @yrouban wrote:

> It is very inconvenient to have non-static const fields.
> In our downstream source we have a field of InlineCost that is changing. With this patch we cannot change the value of the field. The same problem is with locals of InlineCost type.
> Consider reverting this patch, please.

Sure.  I just reverted the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134388/new/

https://reviews.llvm.org/D134388



More information about the llvm-commits mailing list