[PATCH] D134308: AtomicExpand: Use llvm.ptrmask instead of ptrtoint

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:707
+  Type *WordPtrType = PMV.WordType->getPointerTo(PtrTy->getAddressSpace());
+  if (!PtrTy->isOpaquePointerTy())
+    PMV.AlignedAddr =
----------------
jyknight wrote:
> This "if" seems extraneous -- Builder.CreateBitCast is already a no-op internally if it's asked to cast between opaque pointers, right?
Yes, but when opaque pointers are removed, how will we track down all the unnecessary CreateBitCast calls?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134308/new/

https://reviews.llvm.org/D134308