[PATCH] D134323: AtomicExpand: Avoid some operations if the atomic is overaligned

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 23 08:58:25 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:734
+
+  if (!PtrTy->isOpaquePointerTy())
+    PMV.AlignedAddr =
----------------
jyknight wrote:
> JFTR: same comment as previous patch that added this code: don't need the if.
I was thinking this was a handy marker to remove unnecessary code whenever typed pointers are finally dropped


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134323/new/

https://reviews.llvm.org/D134323



More information about the llvm-commits mailing list