[PATCH] D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

The lit tests look familiar, I didn't examine them very closely.
Completed this review pass.



================
Comment at: llvm/unittests/DebugInfo/LogicalView/CodeViewReaderTest.cpp:37-39
+  EXPECT_NE(Parent, nullptr);
+  const LVScopes *Scopes = Parent->getScopes();
+  EXPECT_NE(Scopes, nullptr);
----------------



================
Comment at: llvm/unittests/DebugInfo/LogicalView/CodeViewReaderTest.cpp:84-85
+  const LVLocations *Ranges = Function->getRanges();
+  EXPECT_NE(Ranges, nullptr);
+  ASSERT_EQ(Ranges->size(), 1);
+  LVLocations::const_iterator IterLocation = Ranges->begin();
----------------
You can't continue if Ranges is null; should be able to continue if size() is wrong.


================
Comment at: llvm/unittests/DebugInfo/LogicalView/CodeViewReaderTest.cpp:124-125
+  const LVLines *Lines = Foo->getLines();
+  EXPECT_NE(Lines, nullptr);
+  ASSERT_EQ(Lines->size(), 0x10);
+}
----------------



================
Comment at: llvm/unittests/DebugInfo/LogicalView/CodeViewReaderTest.cpp:150-151
+  const LVLocations *Ranges = Function->getRanges();
+  EXPECT_NE(Ranges, nullptr);
+  ASSERT_EQ(Ranges->size(), 1);
+  LVLocations::const_iterator IterLocation = Ranges->begin();
----------------



================
Comment at: llvm/unittests/DebugInfo/LogicalView/CodeViewReaderTest.cpp:190-191
+  const LVLines *Lines = Foo->getLines();
+  EXPECT_NE(Lines, nullptr);
+  ASSERT_EQ(Lines->size(), 0x0e);
+}
----------------



================
Comment at: llvm/unittests/DebugInfo/LogicalView/CodeViewReaderTest.cpp:216-217
+  const LVLocations *Ranges = Function->getRanges();
+  EXPECT_NE(Ranges, nullptr);
+  ASSERT_EQ(Ranges->size(), 1);
+  LVLocations::const_iterator IterLocation = Ranges->begin();
----------------



================
Comment at: llvm/unittests/DebugInfo/LogicalView/CodeViewReaderTest.cpp:256-257
+  const LVLines *Lines = Foo->getLines();
+  EXPECT_NE(Lines, nullptr);
+  ASSERT_EQ(Lines->size(), 0x0e);
+}
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125784/new/

https://reviews.llvm.org/D125784