[PATCH] D134469: [DirectX] Add DXIL metadata `dx.shaderModel`

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: llvm/test/CodeGen/DirectX/Metadata/shaderModel-vs.ll:5
+; CHECK: !dx.shaderModel = !{![[SM:[0-9]+]]}
+; CHECK: ![[SM]] = !{!"vs", i32 0, i32 0}
----------------
python3kgae wrote:
> Should we report an error for vs_0_0?
Not in the backend. I think we should catch this error in the driver before we start compilation, and in the validator later. The test cases here cover some odd edge cases to ensure the compiler doesn’t crash, but we shouldn’t rely on the backend for producing errors to users unless there are no other alternatives.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134469/new/

https://reviews.llvm.org/D134469