[PATCH] D111968: [TTI] Add OperandValueProperties::OP_NegatedPowerOf2 enum

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 23 06:12:49 PDT 2022


RKSimon added a comment.

In D111968#3811380 <https://reviews.llvm.org/D111968#3811380>, @spatel wrote:

> If one form or the other is easier to deal with from the cost model perspective, that would help decide if we should change the canonicalization further.

div/rem by +/- pow2 will probably benefit from this more as we currently force most divisions by constants will scalarize even though there can be reasonable vector codegen - I need to finish cleaning up the cost tests though first - which is why I simplified this patch down to just the mul case. But as you said, apart from the simplest of cases (such as PR51436), we now canonicalize away from the mul


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111968/new/

https://reviews.llvm.org/D111968



More information about the llvm-commits mailing list