[PATCH] D131807: [DIrectX backend] emit metadata for entry.

Xiang Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 23 00:27:24 PDT 2022


python3kgae added a comment.

In D131807#3809994 <https://reviews.llvm.org/D131807#3809994>, @beanz wrote:

> Rather than copying code from DXC which relies on lots of defined constants, and is very non-LLVM in style, we should focus on adding useful OO abstractions for working with the DXIL metadata.
>
> I refactored the code for writing the `dx.valver` metadata in D134397 <https://reviews.llvm.org/D134397>. That pattern may not apply to all the metadata we need to generate, but we should break away from what DXC did.

Following the pattern in https://reviews.llvm.org/D134469 for `dx.shaderModel`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131807/new/

https://reviews.llvm.org/D131807



More information about the llvm-commits mailing list