[PATCH] D134152: [SimplifyCFG][TranformUtils]Do not simplify away a trivial basic block if both this block and at least one of its predecessors are loop latches.

Thu Sep 22 21:24:21 PDT 2022

davidxl added inline comments.

================
Comment at: llvm/include/llvm/Transforms/Utils/Local.h:160
+//
+// FIXME: Currently the conditions diverge when this function is called by
+// 'JumpThreading' and 'SimplifyCFG'. The divergence should really be unified.
----------------
This fixme seems out of context. Is it needed?

================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:1147
+  //
+  // Alternative option 1, concatenate outer-loop metadata and inner-loop
+  // metadata and attach it to inner-loop metadata and proceed with deleting BB.
----------------
There is no need to document option 1 and option 2 here.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134152/new/

https://reviews.llvm.org/D134152