[PATCH] D132955: [ARM64EC 13/?] Mangle thunk for arm64ec

chenglin.bi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 20:28:38 PDT 2022


bcl5980 added a comment.

In D132955#3788052 <https://reviews.llvm.org/D132955#3788052>, @efriedma wrote:

> Instead of using a separate routine to compute the name, it might make sense to integrate the computation of the name into the actual computation of the signature of the call.  If you write something complicated like this twice, it's hard to ensure the two copies are precisely consistent.

I'm sorry but can you help to explain the `integrate the computation of the name into the actual computation of the signature of the call` ? I haven't write twice so I don't know where the question is.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132955/new/

https://reviews.llvm.org/D132955



More information about the llvm-commits mailing list