[PATCH] D132900: [DWARF] Fix infinite recursion in Type Printer.

Alexander Yermolovich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 15:56:55 PDT 2022


ayermolo added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFTypePrinter.cpp:534
     First = false;
     if (P.getTag() == DW_TAG_unspecified_parameters)
       OS << "...";
----------------
dblaikie wrote:
> ayermolo wrote:
> > Maybe here is a better check? Something like D.getTag() == DW_TAG_subroutine_type, and also check T tag?
> I'm not sure what you're referring to here, unfortunately - you mean adding a condition here in `appendSubroutineNameAfter`, around the `appendQualifiedName` call? I don't think so, but I'm not sure.
> 
> 
Yep exactly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132900/new/

https://reviews.llvm.org/D132900



More information about the llvm-commits mailing list