[PATCH] D131807: [DIrectX backend] emit metadata for entry.

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 14:47:21 PDT 2022


beanz added a comment.

Rather than copying code from DXC which relies on lots of defined constants, and is very non-LLVM in style, we should focus on adding useful OO abstractions for working with the DXIL metadata.

I refactored the code for writing the `dx.valver` metadata in D134397 <https://reviews.llvm.org/D134397>. That pattern may not apply to all the metadata we need to generate, but we should break away from what DXC did.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131807/new/

https://reviews.llvm.org/D131807



More information about the llvm-commits mailing list