[PATCH] D134472: [DAG] Move one-use add of splat to base of scatter/gather

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 14:26:15 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:10669
 bool refineUniformBase(SDValue &BasePtr, SDValue &Index, bool IndexIsScaled,
-                       SelectionDAG &DAG) {
-  if (!isNullConstant(BasePtr) || Index.getOpcode() != ISD::ADD)
+                       SelectionDAG &DAG, SDLoc DL) {
+  if (Index.getOpcode() != ISD::ADD)
----------------
I think we typically pass SDLoc by reference


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134472/new/

https://reviews.llvm.org/D134472



More information about the llvm-commits mailing list