[llvm] 9d236d4 - [SelectionDAGBuilder] Simplify how VTs is created for constrained intrinsics. NFC
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 22 14:22:12 PDT 2022
Author: Craig Topper
Date: 2022-09-22T14:21:22-07:00
New Revision: 9d236d4dabf711ce30cc6049e644458d205afbf7
URL: https://github.com/llvm/llvm-project/commit/9d236d4dabf711ce30cc6049e644458d205afbf7
DIFF: https://github.com/llvm/llvm-project/commit/9d236d4dabf711ce30cc6049e644458d205afbf7.diff
LOG: [SelectionDAGBuilder] Simplify how VTs is created for constrained intrinsics. NFC
All constrained intrinsics return a single value. We can directly
convert it to an EVT instead of going through ComputeValueTypes.
Added:
Modified:
llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
Removed:
################################################################################
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
index 4bc03f70391a..0054fd3dd1a9 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
@@ -7296,11 +7296,6 @@ void SelectionDAGBuilder::visitConstrainedFPIntrinsic(
const ConstrainedFPIntrinsic &FPI) {
SDLoc sdl = getCurSDLoc();
- const TargetLowering &TLI = DAG.getTargetLoweringInfo();
- SmallVector<EVT, 4> ValueVTs;
- ComputeValueVTs(TLI, DAG.getDataLayout(), FPI.getType(), ValueVTs);
- ValueVTs.push_back(MVT::Other); // Out chain
-
// We do not need to serialize constrained FP intrinsics against
// each other or against (nonvolatile) loads, so they can be
// chained like loads.
@@ -7344,7 +7339,9 @@ void SelectionDAGBuilder::visitConstrainedFPIntrinsic(
}
};
- SDVTList VTs = DAG.getVTList(ValueVTs);
+ const TargetLowering &TLI = DAG.getTargetLoweringInfo();
+ EVT VT = TLI.getValueType(DAG.getDataLayout(), FPI.getType());
+ SDVTList VTs = DAG.getVTList(VT, MVT::Other);
fp::ExceptionBehavior EB = *FPI.getExceptionBehavior();
SDNodeFlags Flags;
@@ -7366,8 +7363,7 @@ void SelectionDAGBuilder::visitConstrainedFPIntrinsic(
Opcode = ISD::STRICT_FMA;
// Break fmuladd into fmul and fadd.
if (TM.Options.AllowFPOpFusion == FPOpFusion::Strict ||
- !TLI.isFMAFasterThanFMulAndFAdd(DAG.getMachineFunction(),
- ValueVTs[0])) {
+ !TLI.isFMAFasterThanFMulAndFAdd(DAG.getMachineFunction(), VT)) {
Opers.pop_back();
SDValue Mul = DAG.getNode(ISD::STRICT_FMUL, sdl, VTs, Opers, Flags);
pushOutChain(Mul, EB);
More information about the llvm-commits
mailing list