[PATCH] D134336: [AArch64] Lower multiplication by a constant int to madd

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 22 13:58:22 PDT 2022


efriedma added a comment.

Code changes seem fine.

This sort of change might have some unexpected performance effects... do you have a benchmarking environment to see if there's an impact?



================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-throw.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc -verify-machineinstrs -enable-machine-outliner -mtriple=aarch64-arm-none-eabi < %s | FileCheck %s
----------------
I think this NOTE was intentionally dropped from the test because some of the CHECK lines are manually written?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134336/new/

https://reviews.llvm.org/D134336



More information about the llvm-commits mailing list